search

spiffe / spiffe.io

Source for the SPIFFE and SPIRE project websites. Hosted by the Cloud Native Computing Foundation
https://spiffe.io/
Other
25 stars 59 forks source link

Downloads page out of sync with SPIRE releases #276

Open rturner3 opened 1 year ago

rturner3 commented 1 year ago

As of v1.3.0, SPIRE started publishing binary tarballs and checksum files for Windows. This broke the links on the Downloads page of the website because the association between the release artifact download buttons and the GitHub artifact links assumed that the third and fourth items in the release Assets list were the Linux Extras and Extras checksum files, but now the third and fourth release artifacts in the list are the Windows binary package and checksum. The Assets in the GitHub release are automatically alphabetically ordered, so depending on the ordering is not necessarily stable.

Additionally, for v1.3.0 releases onwards, there are no links to Windows binaries + checksums for SPIRE and SPIRE extras.

Related issues: https://github.com/spiffe/spiffe.io/issues/270 https://github.com/spiffe/spiffe.io/issues/275

Given all these outstanding issues, I think the Downloads page is in need of a bit of an overhaul at this point. Since this has been historically challenging to keep in sync with SPIRE release practices, I wonder if there are any other ways to present the download information on the website that would require less maintenance over time? Some initial ideas that come to mind:

sanderson042 commented 1 year ago

Good points, Ryan. Your first option seems like the path of least resistance and gets my vote:

Trim down the page to link directly to GitHub releases for different projects

sanderson042 commented 1 year ago

I may have time to work on this bug. My plan is the same as my April comment, which is to use Ryan's first option of linking to the GitHub releases pages such as https://github.com/spiffe/spire/releases. I would remove the existing structure of download links by SPIRE version but keep most of the rest of the info on the downloads page. I'd address the two related bugs in this bug's description.

@rturner3 @mchurichi Before I start, does this still sound like a good plan?

mchurichi commented 1 year ago

@sanderson042 Sounds like a good plan to me. Trying to keep up with the artifacts' structure doesn't scale.

mchurichi commented 5 months ago

@sanderson042 just checking if there's anything I can help with, I have some free cycles.

sanderson042 commented 5 months ago

Hi @mchurichi - I started work on this a while ago. I think I'm about 75% done. I hope to have some time to work on this in the coming days. Thanks for offering to help. I'll need that for a PR review for sure and I'll let you know if something else comes up.