search

spiffe / spiffe.io

Source for the SPIFFE and SPIRE project websites. Hosted by the Cloud Native Computing Foundation
https://spiffe.io/
Other
25 stars 59 forks source link

Update getting-started-k8s.md #283

Open cccsss01 opened 1 year ago

cccsss01 commented 1 year ago

New updated tutorial with latest helm chart. Need to wait for PR #119 & PR #120 to be accepeted in spiffe/spiffe-tutorials

netlify[bot] commented 1 year ago

Deploy Preview for spiffe ready!

Name Link
Latest commit 2bf902bc5176a0859985f06b3c650c6cd5f629cb
Latest deploy log https://app.netlify.com/sites/spiffe/deploys/64f76b0e0b45600007b92c36
Deploy Preview https://deploy-preview-283--spiffe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

elinesterov commented 1 year ago

This is awesome! Thank you so much for it! I think it would be nice to have Helm chart installation as a first option to use spire with k8s, but I would also leave the pure yaml files installation there as well (it probably would need some more massaging and updates.

cccsss01 commented 1 year ago

I have PR #19 and #20 to spire-tutorials to create a new folder quickstart-helm, to leaving the original quickstart in place. Still want the original separated? Helm manifest put's it all together.

amoore877 commented 1 year ago

fixing DCO check should be fairly straight forward, though you may need to force push :)

thanks for bringing this up to helm charts sync. there is not an overlap in reviewers for spiffe.io vs helm-charts maintainers, but I'd suspect we primarily do want the helm-chart maintainers review and then general formatting/clarity review by spiffe.io

Looking forward to your continued contributions 🥳

elinesterov commented 1 year ago

Hey @cccsss01 do you mind fixing DCO? Should be straightforward to do this.

elinesterov commented 1 year ago

@cccsss01 I'm not sure that you are referencing to a correct PRs

cccsss01 commented 1 year ago

@cccsss01 I'm not sure that you are referencing to a correct PRs

Correct, Looks like the PR's are referencing the wrong project

I haven't been able to put time into this but it's on my list.

quintessence commented 6 months ago

PRs should be:

(Note: these are not merged, just the correct links)

mchurichi commented 5 months ago

hey @cccsss01 thank you for working on this! do you still have some cycles to finish these PRs? they need the DCO to be fixed and probably a few more changes as the charts have split since this PR. I'd also support the suggestion of keeping the original k8s tutorial and manifests, and adding this as an additional preferred option.

@kfox1111 and other maintainers of the hardened helm chart may also be willing to help with the tutorials and manifests

kfox1111 commented 5 months ago

@mchurichi Would it make sense to rename the original tutorial/manifests as something like "SPIRE from Scratch on Kubernetes"?

Its still quite useful for those wanting to learn how it all works, but not as configurable / tested so "some assembly required" and not as preferred a recommendation?

mchurichi commented 5 months ago

@mchurichi Would it make sense to rename the original tutorial/manifests as something like "SPIRE from Scratch on Kubernetes"?

Its still quite useful for those wanting to learn how it all works, but not as configurable / tested so "some assembly required" and not as preferred a recommendation?

@kfox1111 yes, definitely! we should rename the old tutorial to make it clear that it's not the recommended way anymore.

quintessence commented 5 months ago

Thought - if this is removing an outdated tutorial, perhaps removing the "old way" is the way to go? To prevent confusion and help people with onboarding.

cccsss01 commented 5 months ago

I think this should be closed in favor of what keven fox has done.

kfox1111 commented 5 months ago

Seems like the consensus is to move the old getting started to a new name involving "from scratch" and then make the existing page just a small blurb helping the user choose links something like:

  1. the hardened chart install doc
  2. the from scratch quickstart
  3. When the flex chart works, the flex quickstart

?

Should we close this pr and start a new one for that work, or rework this one to do those things intead?

elinesterov commented 5 months ago

Just my 2 cents here: I helped to kick off the helm chart work, and I thought that it would be a quick start guide for a Kubernetes because you can do helm install spire. I don't think we should throw away the existing k8s quick start guide. It should be renamed to something like Running SPIRE on k8s in a hard way or something similar. For people who want to understand how to run it in the details using k8s yaml files without getting through the complexities of helm charts.