search

spiffe / spiffe.io

Source for the SPIFFE and SPIRE project websites. Hosted by the Cloud Native Computing Foundation
https://spiffe.io/
Other
25 stars 59 forks source link

Fixing a few broken URLs from older PRs #299

Closed quintessence closed 5 months ago

quintessence commented 6 months ago

Description of the change Fixing broken URLs that were fixed in other open PRs. See list.

Which issue this PR fixes

netlify[bot] commented 6 months ago

Deploy Preview for spiffe ready!

Name Link
Latest commit 782220830c213d07fa86db930bc09fd64d802d20
Latest deploy log https://app.netlify.com/sites/spiffe/deploys/65eb982407e3140008fc2bdc
Deploy Preview https://deploy-preview-299--spiffe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

quintessence commented 5 months ago

For this PR - can we squash the commit since it pulled in a duplicate of the same HeadBucket commit. I'll delete and re-create my fork after, something weird must've happened when I tried to sync my fork.

sanderson042 commented 5 months ago

In git terms, "squash the commits" means to combine multiple commits into one commit. It doesn't mean to delete a commit. I think the safest course here is to close this PR and try one more time.

Before starting the new branch for the new PR, be sure to set the working branch to main (git checkout master) and do git pull upstream master (or an equivalent using your git tool of choice). Then create your new branch and recreate these changes on that branch. Publish the new branch as a draft and make sure that pesky old commit doesn't show up. If it's good, then convert the draft PR to a real PR by clicking Ready For Review in GitHub.

quintessence commented 5 months ago

Got it - I'm going to go ahead and try to repair my fork then - issues got worse when I used the "sync fork feature" which had unintended consequences. I'll also delete PR #300 and I'll make both these in one PR for simplicity in the next one.