search

spiffe / spiffe.io

Source for the SPIFFE and SPIRE project websites. Hosted by the Cloud Native Computing Foundation
https://spiffe.io/
Other
25 stars 59 forks source link

Consolidating a few past PRs #302

Closed quintessence closed 3 months ago

quintessence commented 5 months ago

Description of the change Fixing broken URLs that were fixed in other open PRs (listed below) and also removed references to Node Resolver (PR #262 ).

Which issue this PR fixes

netlify[bot] commented 5 months ago

Deploy Preview for spiffe ready!

Name Link
Latest commit f7df7db2819b746f3043bfd8770675b0a490b228
Latest deploy log https://app.netlify.com/sites/spiffe/deploys/663e2037a6fc7100072ea65f
Deploy Preview https://deploy-preview-302--spiffe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

quintessence commented 5 months ago

For the server diagram, a couple things:

quintessence commented 5 months ago

Hey @mchurichi would you mind reviewing these? :)

quintessence commented 5 months ago

Hello! I saw that main was pulled into the branch and wanted to break out (for ease of reading) what needs to be resolved on the PR so it can be merged :)

evan2645 commented 4 months ago

I sync’d up with @quintessence last week on this, made a suggestion which I think has been accepted. Also, just to remove the conversation around DCO and attribution, we backed out the commit related to https://github.com/spiffe/spiffe.io/pull/285 ... also had a look at https://github.com/spiffe/spiffe.io/pull/262 which included some changes now found in this PR, but those changes were limited to focused deletions etc .. I thought it’s probably fine to include, but let me know if you prefer to cherry pick there as well

quintessence commented 4 months ago

It looks like commit 7879fb7 has a failed DCO, even though the signature is there and is also on prior commits. Is there a way to re-trigger the DCO check? A bot command to run or similar?

quintessence commented 4 months ago

I'm wondering if it's reading the "fail" from 37c2460 as a DCO failure - but it wasn't, the Deploy Preview failed there for some reason.

quintessence commented 4 months ago

Tried another force push with signature just in case, but alas no 🤔

mchurichi commented 4 months ago

@quintessence thanks for fixing the commit history :) this looks good to me, it just needs to be updated with the latest changes from master and that should be it. @sanderson042 do you have any pending comment?

quintessence commented 3 months ago

🎉