Closed quintessence closed 3 months ago
Name | Link |
---|---|
Latest commit | f7df7db2819b746f3043bfd8770675b0a490b228 |
Latest deploy log | https://app.netlify.com/sites/spiffe/deploys/663e2037a6fc7100072ea65f |
Deploy Preview | https://deploy-preview-302--spiffe.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
For the server diagram, a couple things:
Hey @mchurichi would you mind reviewing these? :)
Hello! I saw that main was pulled into the branch and wanted to break out (for ease of reading) what needs to be resolved on the PR so it can be merged :)
I syncβd up with @quintessence last week on this, made a suggestion which I think has been accepted. Also, just to remove the conversation around DCO and attribution, we backed out the commit related to https://github.com/spiffe/spiffe.io/pull/285 ... also had a look at https://github.com/spiffe/spiffe.io/pull/262 which included some changes now found in this PR, but those changes were limited to focused deletions etc .. I thought itβs probably fine to include, but let me know if you prefer to cherry pick there as well
It looks like commit 7879fb7 has a failed DCO, even though the signature is there and is also on prior commits. Is there a way to re-trigger the DCO check? A bot command to run or similar?
I'm wondering if it's reading the "fail" from 37c2460 as a DCO failure - but it wasn't, the Deploy Preview failed there for some reason.
Tried another force push with signature just in case, but alas no π€
@quintessence thanks for fixing the commit history :) this looks good to me, it just needs to be updated with the latest changes from master and that should be it. @sanderson042 do you have any pending comment?
π
Description of the change Fixing broken URLs that were fixed in other open PRs (listed below) and also removed references to Node Resolver (PR #262 ).
Which issue this PR fixes