search

spiffe / spiffe.io

Source for the SPIFFE and SPIRE project websites. Hosted by the Cloud Native Computing Foundation
https://spiffe.io/
Other
25 stars 59 forks source link

Inaccurate statement in the docs for server ClusterRole and ClusterRoleBinding #310

Open angabini opened 4 months ago

angabini commented 4 months ago

The doc states that:

https://github.com/spiffe/spiffe.io/blob/91160595be2ce295331a8e92a396bb003dfa1710/content/docs/latest/deploying/install-server.md?plain=1#L129

Though, the rule in ClusterRole definitions is:

- apiGroups: ["authentication.k8s.io"]
  resources: ["tokenreviews"]
  verbs: ["create"]

Which seems to have nothing to do with configmaps.

I believe the statement applies to Role/RoleBinding. So, the doc should be updated and possibly needs and addition for why ClusterRole /ClusterRoleBinding are needed.