search

spiffe / spiffe.io

Source for the SPIFFE and SPIRE project websites. Hosted by the Cloud Native Computing Foundation
https://spiffe.io/
Other
25 stars 59 forks source link

k8s quickstart: Fix namespace in workload registration apply #311

Open jsnctl opened 4 months ago

jsnctl commented 4 months ago

Description of the change

Amends the namespace used when registering the workload in the Kubernetes Quickstart example. This is erroneously set to default in the example kubectl apply, it should be set to spire

Which issue this PR fixes

Not in this repo, but this was raised in spire-tutorials last September: https://github.com/spiffe/spire-tutorials/issues/123

netlify[bot] commented 4 months ago

Deploy Preview for spiffe ready!

Name Link
Latest commit daa799b5cfaf51bda8d96f1c40ee01defeca9f8e
Latest deploy log https://app.netlify.com/sites/spiffe/deploys/663f5e41c85a59000806efa3
Deploy Preview https://deploy-preview-311--spiffe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

akaloti commented 3 months ago

Doesn't the tutorial command for the workload container put it in default namespace? (the kubectl apply -f client-deployment.yaml) If changing the namespace referenced in the registration entry, I think you'd need to change the command too.