spiffe / spire-controller-manager

Kubernetes controller manager that reconciles workload registration and federation relationships.
Apache License 2.0
47 stars 36 forks source link

ENABLE_WEBHOOKS=false does not completely disable webhook machinery #293

Closed azdagron closed 6 months ago

azdagron commented 6 months ago

Kubebuilder v4 code generation added some conditional statements around webhook registration with the manager that are skipped when ENABLE_WEBHOOKS=false.

We didn't test this out before the release and unfortunately there are some more statements that need to be skipped if we truly want to disable the webhook functionality (e.g. setting up the webhook server and obtaining webhook credentials).