spiffe / spire

The SPIFFE Runtime Environment
https://spiffe.io
Apache License 2.0
1.82k stars 478 forks source link

Transition the Database Entry Event handling from experimental to production #4985

Open edwbuck opened 8 months ago

edwbuck commented 8 months ago

After a sufficient amount of time has passed, we should remove the experimental categorization of the database entry event performance improvements.

Much of the testing of the experimental feature has already been performed in production environments. This issue is to coordinate any remaining required efforts and the final code changes necessary to effect the change.

faisal-memon commented 7 months ago

Bugs that need to be fixed:

  1. 5030

  2. 5037

edwbuck commented 7 months ago

@evan2645 Please retarget this for 1.11.0. The issues at Uber are just too close to the 1.10.0 release to have enough observation period to build confidence that no new issues are discovered / introduced.

stevend-uber commented 7 months ago

Can we add an exit criteria for this feature to be production ready to have a holistic integration test for all of the different workflows we've talked about in the past few months?

I think this workflow that @faisal-memon is working on https://github.com/faisal-memon/spire/pull/344, is both valuable but complex and we should have a deep integration test for the whole event-based feature to give confidence for other users.

edwbuck commented 7 months ago

@stevend-uber The only bug that we have encountered that is a race condition in the relational database, one that is well known in database access programming and has a known solution.

The solution you mention "is complex" is, in simple terms:

For handling the request of a holistic integration test, I would like to note that the unit testing can capture detecting skipped ids, and note that unit testing can check that skipped ids are processed in order prior to the currently existing batch processing. This would put the entire solution under test, and is the current test plan.

nweisenauer-sap commented 4 weeks ago

Any news on this? Will it be moved to production config with 1.12 ?