search

spiffe / spire

The SPIFFE Runtime Environment
https://spiffe.io
Apache License 2.0
1.78k stars 472 forks source link

Remove deprecated ttl flag #5254

Closed azdagron closed 1 week ago

azdagron commented 3 months ago

The CLI has long since deprecated the -ttl flag in favor of the SVID specific flags -x509SVIDTTL and -jwtSVIDTTL. The deprecated flag should be removed.

ayushrakesh commented 3 months ago

@azdagron I want to work on this issue, can you explain it more?

amoore877 commented 1 month ago

@ayushrakesh see https://github.com/spiffe/spire/blob/main/cmd/spire-server/cli/entry/create.go#L51 , https://github.com/spiffe/spire/blob/main/cmd/spire-server/cli/entry/update.go#L48 

    // TTL for x509 and JWT SVIDs issued to this workload, unless type specific TTLs are set.
    // This field is deprecated in favor of the x509SVIDTTL and jwtSVIDTTL fields and will be
    // removed in a future release.

we want to remove ttl flag entirely in favor of the credential primitive-specific x509 / jwt flags. Probably spire-server.md also needs updating on this removal.

heymarcel commented 3 weeks ago

I'm working on this issue.

heymarcel commented 3 weeks ago

I've opened a PR: https://github.com/spiffe/spire/pull/5483

azdagron commented 1 week ago

Resolved by #5483.