Consider using gRPC metrics from go-grpc-middleware

spiffe / spire

The SPIFFE Runtime Environment

https://spiffe.io

Apache License 2.0

1.77k stars 469 forks source link

Consider using gRPC metrics from go-grpc-middleware #5305

Open AlexZzz opened 2 months ago

AlexZzz commented 2 months ago

Version: 1.9.5
Platform: any
Subsystem: server and agnet

Hi! There're standard prometheus metrics that are exposed by grpc-go-middleware. Using it prevents teams from creating hundreds of dashboards about gRPC communication.

It would be nice to see these metrics in spire.

evan2645 commented 1 month ago

Thanks for opening this @AlexZzz

As part of this work, we should take a look at what overlap there is (if any) with existing SPIRE metrics. We should probably prefer metrics coming from this package over our own when/where possible.