search

spiffyjr / spiffy-authorize

SpiffyAuthorize is an authorization module for SpiffyCms (but can be used standalone).
3 stars 2 forks source link

Cleanup identity provider #10

Closed bakura10 closed 11 years ago

bakura10 commented 11 years ago

Rename identity provider classes (you were using both AuthenticationProvider and IdentityProvider across the code base, but IdentityProvider makes more sense).

Also properly handle injection of default and guest role from module options.

This will likely cause some conflicts when you will merge https://github.com/spiffyjr/spiffy-authorize/pull/8

all tests have been updated and pass

spiffyjr commented 11 years ago

AuthenticationProvider is a specific type of IdentityProvider that uses Zend\Authentication\AuthenticationService to get the identity.

bakura10 commented 11 years ago

AuthenticationIdentityProvider ? :D

Envoyé de mon iPhone

Le 25 oct. 2013 à 15:09, Kyle Spraggs notifications@github.com a écrit :

AuthenticationProvider is a specific type of IdentityProvider that uses Zend\Authentication\AuthenticationService to get the identity.

— Reply to this email directly or view it on GitHub.

spiffyjr commented 11 years ago

And this?

bakura10 commented 11 years ago

Should be ok @spiffyjr . I keep with AuthenticationProvider name.