RockPaperScissors

[Niiola]

I will implement it now On Mon, Oct 17, 2022 at 7:03 PM Ujjawal Saini @.***> wrote:

@.**** commented on this pull request.

In main.py https://github.com/spignelon/virtual-assistant/pull/20#discussion_r997361351 :

@@ -129,44 +154,10 @@ def respond(voice_data): mixer.setvolume(percentage)

-def PaperScissors(voice_data):

I think here you have deleted the changed you made in your previous commit 2f81764 https://github.com/spignelon/virtual-assistant/commit/2f817641635afd3604a5b6a750d674d5049076d4 in which you have added PaperScissors() function, an implementation of rock, paper, scissors game.

— Reply to this email directly, view it on GitHub https://github.com/spignelon/virtual-assistant/pull/20#pullrequestreview-1144598248, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVQLHJK6ASYL7YXGGCCCRB3WDWIGVANCNFSM6AAAAAARG7CM7U . You are receiving this because you authored the thread.Message ID: @.***>

[Niiola]

Should I add both task at the same time and the push?

On Mon, Oct 17, 2022 at 7:04 PM Nafisa Oladele @.***> wrote:

I will implement it now

On Mon, Oct 17, 2022 at 7:03 PM Ujjawal Saini @.***> wrote:

@.**** commented on this pull request.

In main.py https://github.com/spignelon/virtual-assistant/pull/20#discussion_r997361351 :

@@ -129,44 +154,10 @@ def respond(voice_data): mixer.setvolume(percentage)

-def PaperScissors(voice_data):

I think here you have deleted the changed you made in your previous commit 2f81764 https://github.com/spignelon/virtual-assistant/commit/2f817641635afd3604a5b6a750d674d5049076d4 in which you have added PaperScissors() function, an implementation of rock, paper, scissors game.

— Reply to this email directly, view it on GitHub https://github.com/spignelon/virtual-assistant/pull/20#pullrequestreview-1144598248, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVQLHJK6ASYL7YXGGCCCRB3WDWIGVANCNFSM6AAAAAARG7CM7U . You are receiving this because you authored the thread.Message ID: @.***>

[spignelon]

@Niiola the best thing you can do is create two new pull requests, one in which you implemented the rock paper scissors game 2f817641635afd3604a5b6a750d674d5049076d4, and the other in which you have added some basic commands 16598f30a1faabe4ec4e4b33c72c4d2cb6a9eafd.

This way it will be neater, and you'll get your two separate PRs done.

Issues #14, #18

[Niiola]

I am unable to make 2 pull request

On Mon, Oct 17, 2022 at 7:07 PM Ujjawal Saini @.***> wrote:

@Niiola https://github.com/Niiola the best thing you can do is create two new pull requests, one in which you implemented the rock paper scissors game 2f81764 https://github.com/spignelon/virtual-assistant/commit/2f817641635afd3604a5b6a750d674d5049076d4, and the other in which you have added some basic commands 16598f3 https://github.com/spignelon/virtual-assistant/commit/16598f30a1faabe4ec4e4b33c72c4d2cb6a9eafd .

This way it will be neater, and you'll get your two separate PRs done.

*Issues #14 https://github.com/spignelon/virtual-assistant/issues/14,

18 https://github.com/spignelon/virtual-assistant/issues/18*

— Reply to this email directly, view it on GitHub https://github.com/spignelon/virtual-assistant/pull/20#issuecomment-1281270107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVQLHJJ7YWWTIBGTDVROMUDWDWIV7ANCNFSM6AAAAAARG7CM7U . You are receiving this because you were mentioned.Message ID: @.***>

[spignelon]

I am unable to make 2 pull request

https://www.youtube.com/watch?v=rgbCcBNZcdQ Maybe search on YouTube or better check the the digital resources for hacktoberfest.

https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

You just have to repeat it twice, once with rock paper scissors #18 and once with basic commands #14.

[Niiola]

Done

On Tue, Oct 18, 2022 at 7:28 AM Ujjawal Saini @.***> wrote:

I am unable to make 2 pull request

https://www.youtube.com/watch?v=rgbCcBNZcdQ Maybe search on YouTube or better check the the digital resources for hacktoberfest.

https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

You just have to repeat it twice, once with rock paper scissors #18 https://github.com/spignelon/virtual-assistant/issues/18 and once with basic commands #14 https://github.com/spignelon/virtual-assistant/issues/14.

— Reply to this email directly, view it on GitHub https://github.com/spignelon/virtual-assistant/pull/20#issuecomment-1281873677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVQLHJJJ7DUSETXVYCDXIC3WDY7PVANCNFSM6AAAAAARG7CM7U . You are receiving this because you were mentioned.Message ID: @.***>