Defense against ITS Service Notes - Githubissues

spike-2 / Spike-2

Server specific Discord bot

https://spike-2.github.io

1 stars 0 forks source link

Defense against ITS Service Notes #52

Closed brandoningli closed 3 years ago

brandoningli commented 3 years ago

Related bugs/feature requests

Resolves #14

Describe the changes

Set a timeout for ITS service notes requests and properly handle exceptions.

Expected behavior

Spike shouldn't crash for random exceptions regarding service notes anymore.

Screenshots

New npm dependencies

Requires node >=15.0.0

Testing Instructions

[ ] Change the timeout at the top of truman-its-service-notes.js to 10ms.
[ ] From src, run node plugins/itsServiceNotes/truman-its-service-notes.js
[ ] Verify that a Timeout is printed

Additional context

brandoningli commented 3 years ago

Tested already on Simone with the short timeout, and it console.errored as expected.