Default time unit when add a note is hours

spike008t / redmine_advanced_issues

Advanced issues for redmine

http://blog.spikie.info

7 stars 10 forks source link

Default time unit when add a note is hours #17

Open buxx opened 10 years ago

buxx commented 10 years ago

After using #12: Now we can use the time form when add a note, but the time unit is interpreted as hours, not with plugin default configuration (days for me) time unit.

spike008t commented 10 years ago

ok, I'm gonna check this today or tomorrow if I got the time!

buxx commented 10 years ago

Cool, thank's !

spike008t commented 9 years ago

Sorry for the delay. I'm afraid to say that actually we couldn't make that work correctly without to make any modification into the redmine's source code.

I've created an issue in redmine to be able to edit the timeunit (here: http://www.redmine.org/issues/17900)

By all the way, try this patch if you really need it : https://gist.github.com/spike008t/c002b782b3ebe02c5624

buxx commented 9 years ago

Ok, i see. Thank very much i will maybe apply this patch (chief advisory ^^)

buxx commented 9 years ago

Additional question:

call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})

It is not possible to manipulate times with issue.time_entries instead of time_entry ?

spike008t commented 9 years ago

Nope. I've tried it (and many other solutions...), but in fact isse.time_entries return me an ActiveRecord::Relation object and not an array in the patch method.

buxx commented 9 years ago

Arf Ok, thank you for your work !

buxx commented 9 years ago

Hi again ! I was trying to update redmine to fix other bugs about your plugin. But i don't success (nt ruby devlopper). So, i list for you these bugs, if you can update your patch it could be very appreciated. So bugs found:

When tracker, state/project issue is changed, the form is Ajax reloaded. When reloaded the time is changed. For exemple: if "1" (day by default) is in field. After ajax reload we have 0.14. The 1 day has been converted with error.
When we add a note with time, if i set "3h" (day by default) it's converted in 3days. the 'h' is not interpredted. Thank's a lot !

muby commented 6 years ago

I know this post is very old, but I have the same problem :

When tracker, state/project issue is changed, the form is Ajax reloaded. When reloaded the time is changed. For exemple: if "1" (day by default) is in field. After ajax reload we have 0.14. The 1 day has been converted with error.

I don't know how to patch it, to avoid automatic calculation of the estimated_time during tracker change or during status change in edit mode.

If you have just an idea, it could be usefull. Thanks