search

spikespaz / firefox-nativedark

Dynamic theme for Firefox Quantum that colorizes the title bar, tabs, and URL bar based on your Windows accent color.
https://addons.mozilla.org/firefox/addon/native-dark/
MIT License
86 stars 8 forks source link

Find bar not following accent color #26

Open Keith94 opened 6 years ago

Keith94 commented 6 years ago

I chose this accent color in Windows,

applicationframehost_2018-05-15_21-29-13

And my findbar at the bottom looks like this as a result (is there a way to follow accent color?)

firefox_2018-05-15_21-24-02

HRussellZFAC023 commented 6 years ago

image in addition, if the difference mode is set to lighter, the findbar is unreadable.

Keith94 commented 6 years ago

Yes, that's a pretty nasty bug!

spikespaz commented 6 years ago

@HRussell63250 I think that this is an issue related to not setting the color for the bottom bar. Did this only start happening after the FF 60 update? It appears to be adding a white overlay to a transparent or white background. I think I may be able to fix this, I'm not sure though.

Keith94 commented 6 years ago

Fun fact: If Unfocused theme is set to Light titlebar, findbar is displayed correctly only when inactive.

image

HRussellZFAC023 commented 6 years ago

Yup. I think it is related to the new theme API introduced: https://developer.mozilla.org/en-US/Firefox/Releases/60

martinguti95 commented 6 years ago

Hi,

I'm assigning this to me. I've been able to replicate what @Keith94 raised about the Unfocused theme and the Light Titlebar and I think that there's another style overriding the value of the accent color when focused

martinguti95 commented 6 years ago

Checking the release notes of FF 61 https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/61#WebExtensions , now the toolbar attributes apply also to the find bar.

When the window is selected, a default value is applied to the toolbar. That's what is causing the bug.

spikespaz commented 6 years ago

@martinguti95 Yes, and that snippet of code in one of the commits solves the issue, however there are problems with it as you will find out. If you see another way to fix this, I'm all ears.