search

spikespaz / search-deflector

A small program that forwards searches from Cortana to your preferred browser and search engine.
MIT License
890 stars 52 forks source link

"Search Deflector launch failed" with link from Settings #126

Open wengh opened 3 years ago

wengh commented 3 years ago

Bug Description

If you have any other details, replace this line, otherwise delete it.

File: std\windows\registry.d

Line: 510

Message:

There was an error deflecting your search. Passed URI is:   microsoft-edge:https://www.bing.com/search?q=%E5%A6%82%E4%BD%95%E5%90%91%20windows%2010%20%E7%94%B5%E8%84%91%E6%B7%BB%E5%8A%A0%E5%A4%9A%E4%B8%AA%E7%9B%91%E8%A7%86%E5%99%A8&form=B00032&ocid=SettingsHAQ-BingIA&mkt=zh-CN

How to Reproduce

Steps to reproduce the behavior:

  1. Open Settings app
  2. Click System
  3. Click Set up multiple monitors link on the right side

Expected Behavior

Should open the link in browser

Environmental Details

Browser: Vivaldi (same error occurs with IE and Edge)

Windows Version 2009
Build Number 19042
Edition Professional
Insiders Preview
System Language Chinese (didn't test other languages, may be related to the bug)
Search Deflector Language English (same error occurs with other languages)
Uberck commented 3 years ago

Also experiencing this issue, looking at the code, line 53 in searchdeflector.d is just the error message we are seeing? Can we get some help please?

radoslew commented 3 years ago

Also experiencing this issue, looking at the code, line 53 in searchdeflector.d is just the error message we are seeing? Can we get some help please?

same

spikespaz commented 3 years ago

I sincerely apologize for the extremely long wait.

I want to develop software but it requires a significant amount of time. It does not earn money quickly without sponsorship/employment. I'm currently working in an understaffed retail store, and this does not allow for the time that must be invested to maintain updates to software consistently.

I have recently purchased a new computer, as my previous currently has no replacement parts on market. Money is tight so I was unable to work on all of the issues that kept piling up. I'm panning a major release soon-ish, there is no eta.

Time is money.

wengh commented 3 years ago

I sincerely apologize for the extremely long wait.

I want to develop software but it requires a significant amount of time. It does not earn money quickly without sponsorship/employment. I'm currently working in an understaffed retail store, and this does not allow for the time that must be invested to maintain updates to software consistently.

I have recently purchased a new computer, as my previous currently has no replacement parts on market. Money is tight so I was unable to work on all of the issues that kept piling up. I'm panning a major release soon-ish, there is no eta.

Time is money.

It turns out that the function getSearchInfo(uri) assumes that the search query is encoded twice (i.e. microsoft-edge:<something>?url=https%3A%2F%2Fwww.bing.com%2Fsearch%3Fq%3D<query>) but the Settings app links directly to Bing (i.e. microsoft-edge:https://www.bing.com/search?q=<query>).

Changes in #141 should fix this.