search

spillerrec / imgviewer

Customizable image viewer with minimalistic interface
2 stars 1 forks source link

imgviewer tends to crash on directory modifications #45

Closed spillerrec closed 8 years ago

spillerrec commented 8 years ago

This seems quite unstable lately, and I'm not quite sure why. Something must be wrong in fileManager however, as it happens even if the modified file is not an image...

spillerrec commented 8 years ago

This is because of the QObject::disconnect() in imageViewer::change_image(). Not quite sure why, but perhaps the QObject has already been destroyed? Something is quite wrong in the code now however, it appears to reload images each time the directory is modified, even though it is not an image which is causing it. This should definitively not happen!

spillerrec commented 8 years ago

Avoiding the disconnect seems to have fixed it mostly, but it still appears to crash once in a blue moon. This could as well be caused by the image loading crashing on partial files. We should create a fuzzing application which randomly and rapidly moves flies back and forth from two directories, to provoke crashes more easily. If this works perfectly, we could move the contents with random write speeds to check the plugins.

spillerrec commented 8 years ago

It have been going for over an hour at 10 Hz without any crashes. That does not cover edge cases at all, but it looks like it is stable enough for this milestone. I will try it out for a while in practice before closing this issue though.

spillerrec commented 8 years ago

Haven't had any issues so far, but I wouldn't be surprised if this pop up again someday...