spillz / picty

picty helps you manage photos
57 stars 9 forks source link

No thumbnails at very large collection. #15

Open tmsd2001 opened 7 years ago

tmsd2001 commented 7 years ago

Hello

with a large collection 100k+ i see only the last thumbnails. With recreate thumbnails i can see at one point the first thumbnail was remove when a new thumbnail at the end was create. Version is xubuntu 16.04.01 and picty testing-r800.

regards Thomas

Poikilos commented 6 years ago

I also get this problem with ico and png and most jpg files in updated Ubuntu 16.04 and picty (as of git version cloned today ) If I run picty from terminal and load the library, NOTE: If I run picty in terminal and open the directory, I do not get any errors when jpg file is loaded, output for each jpg is like:

loading metadata for item redacted/01_student_data_files/08_powerpoint/chapter_03/p03G_Catering.jpg
opening preview 1
read took 0.0316870212555
Adding redacted/01_student_data_files/08_powerpoint/chapter_03/p03G_Catering.jpg to collection <picty.collectiontypes.localdir.Device instance at 0x7f2cd3f9a5f0>

no jpg thumbnails picty ubuntu 16 04 xenial example of jpg that works (apparently from http://pcwallart.com/happy-koala-wallpaper-4.html which I found by images.google.com upload feature): koala - copy example of image that does not work (this one doesn't have a thumbnail in Thunar either so may have no builtin thumnail) -- source is Thaumcraft: exanimis example of image that does not work (this one doesn't have a thumbnail in Thunar but DOES in nautilus AFTER I open it in GNOME image viewer) -- source is Thaumcraft: corpus

Poikilos commented 6 years ago

Right-click, "Select All " Right-click, "Recreate Thumnails," works. Maybe you should add an option (on by default) to "Recreate missing thumbnails automatically"

Poikilos commented 6 years ago

However just so you know sometimes its PIL's fault (can't parse):

Opened with GDK
Creating thumbnail for redacted/monster-slide A.psd /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide A.psd
/run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide A.psd has no thumbnail.
Cannot decode file /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide A.psd
Error creating thumbnail for redacted/monster-slide A.psd
Traceback (most recent call last):
  File "/usr/share/picty/picty/imagemanip.py", line 963, in make_thumb
    image = p.close()
  File "/usr/lib/python2.7/dist-packages/PIL/ImageFile.py", line 423, in close
    raise IOError("cannot parse this image")
IOError: cannot parse this image

Creating thumbnail for redacted/bed empty.jpg /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/bed empty.jpg

where redacted is a username

this only happened in rare cases --the rest of the thumbnails were generated

spillz commented 6 years ago

What options do you have checked in the advanced part of the collection settings?

There are probably a few things that can be done to the collection settings as well as some improvements to the chain of logic that determines which image thumbnailer is used (exiv2, gtk, pil, dcraw etc). Which file types are causing the problems?

On Dec 6, 2017 6:20 PM, "Jacob Gustafson" notifications@github.com wrote:

Right-click, "Select All " Right-click, "Recreate Thumnails," works. Maybe you should add an option (on by default) to "Recreate missing thumbnails automatically"

However just so you know sometimes its PIL's fault (can't parse):

Opened with GDK Creating thumbnail for redacted/monster-slide A.psd /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide A.psd /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide A.psd has no thumbnail. Cannot decode file /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide A.psd Error creating thumbnail for redacted/monster-slide A.psd Traceback (most recent call last): File "/usr/share/picty/picty/imagemanip.py", line 963, in make_thumb image = p.close() File "/usr/lib/python2.7/dist-packages/PIL/ImageFile.py", line 423, in close raise IOError("cannot parse this image") IOError: cannot parse this image

Creating thumbnail for redacted/bed empty.jpg /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/bed empty.jpg

where redacted is a username

this only happened in rare cases --the rest of the thumbnails were generated

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/spillz/picty/issues/15#issuecomment-349807927, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFd5b8fozyERkGWcY6hj30vL06jEKyNks5s9yElgaJpZM4KHbJL .

Poikilos commented 6 years ago

I am not using a collection, I am opening a folder from the welcome screen of picty I would assume that would use the default options (below were seen as default when creating a new collection): Include sub-directories: yes Rescan for changes after opening: yes Monitor image folders for changes: yes Load image metadata: yes Use metadata sidecars for unsupported formats: no Use embedded thumbnails if available: no Store thumbnails in cache: yes Thumbnail storage: Gnome Desktop Thumbnail Cache (User's Home) Trash Location: User's Trash Folder

However, I doubt those settings are being used by the open folder option, since only certain things have thumbnails before clicking "Recreate thumbnails" but I don't know the code so I'm not sure.

Poikilos commented 6 years ago

x264-encoded mp4 too:

loading metadata for item redacted/3D Animation/3Da13 Walk Cycles/3Da13Walk Cycles0001-0048_x264.mp4
Error reading metadata for /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/3D Animation/3Da13 Walk Cycles/3Da13Walk Cycles0001-0048_x264.mp4
Traceback (most recent call last):
  File "/usr/share/picty/picty/metadata/metadata2.py", line 117, in load_metadata
    rawmeta.read()
  File "/usr/lib/python2.7/dist-packages/pyexiv2/metadata.py", line 107, in read
    self.__image = self._instantiate_image(self.filename)
  File "/usr/lib/python2.7/dist-packages/pyexiv2/metadata.py", line 79, in _instantiate_image
    return libexiv2python._Image(filename)
IOError: /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/3D Animation/3Da13 Walk Cycles/3Da13Walk Cycles0001-0048_x264.mp4: The file contains data of an unknown image type

Adding redacted/3D Animation/3Da13 Walk Cycles/3Da13Walk Cycles0001-0048_x264.mp4 to collection <picty.collectiontypes.localdir.Device instance at 0x7fdd4cbab710>
spillz commented 6 years ago

Defaults aren't the same for opening folders that way, although maybe they should be. In particular it doesn't "store in cache" and I think that means it won't try alternative thumb readers if the built-in thumbnails aren't present.

On Dec 6, 2017 8:32 PM, "Jacob Gustafson" notifications@github.com wrote:

I am not using a collection, I am opening a folder from the welcome screen of picty I would assume that would use the default options (below were seen as default when creating a new collection): Include sub-directories: yes Rescan for changes after opening: yes Monitor image folders for changes: yes Load image metadata: yes Use metadata sidecars for unsupported formats: no Use embedded thumbnails if available: no Store thumbnails in cache: yes Thumbnail storage: Gnome Desktop Thumbnail Cache (User's Home) Trash Location: User's Trash Folder

However, I doubt those settings are being used by the open folder option, since only certain things have thumbnails before clicking "Recreate thumbnails"

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/spillz/picty/issues/15#issuecomment-349832732, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFd5SGJ0S-PRErDG_PoXeLJ-wvlJfGcks5s90AUgaJpZM4KHbJL .

Poikilos commented 6 years ago

another one that didn't work, since you asked (not all psd files but some--see attached zipped psd file--opens in GIMP). I tried to add that whole folder as a collection, and thought it was done because the window was finally non-blank after blocking io when adding a collection was finished, but after I clicked x to close the program I got:

Creating thumbnail for redacted/monster-slide 4.psd /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide 4.psd
Opened with PIL
cached at /home/local/FBM/jgustafson/.thumbnails/normal/0fb5fc793b861cdbafa7aa5045ddb74d.png
Creating thumbnail for redacted/monster-slide 4A.psd /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide 4A.psd
/usr/share/picty/picty/uitools/floats.py:128: GtkWarning: gtk_toolbar_remove: assertion 'content_to_remove != NULL' failed
  self.mainframe.toolbar1.remove(p.toggle)
/run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide 4A.psd has no thumbnail.
Cannot decode file /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide 4A.psd
Error creating thumbnail for redacted/monster-slide 4A.psd
Traceback (most recent call last):
  File "/usr/share/picty/picty/imagemanip.py", line 963, in make_thumb
    image = p.close()
  File "/usr/lib/python2.7/dist-packages/PIL/ImageFile.py", line 423, in close
    raise IOError("cannot parse this image")
IOError: cannot parse this image

Error removing watch
Traceback (most recent call last):
  File "/usr/share/picty/picty/fstools/monitor2.py", line 29, in stop
    self.wm.rm_watch(wd.values(),rec=self.recursive)
  File "/usr/lib/python2.7/dist-packages/pyinotify.py", line 2158, in rm_watch
    del self._wmd[awd]
KeyError: 16577

SAVED VIEW <picty.collectiontypes.simpleview.SimpleView instance at 0x7fdd4cae5320>
no map source

monster-slide 4A.psd.zip

Poikilos commented 6 years ago

also there's dds, which can be decoded by ImageMajick which I don't have installed but it could be used if present: https://superuser.com/questions/159379/convert-dds-to-png-using-linux-command-line

spillz commented 6 years ago

Nothing should block when scanning a collection. If it does it's a bug.

On Dec 6, 2017 10:10 PM, "Jacob Gustafson" notifications@github.com wrote:

another one that didn't work, since you asked (not all psd files but some). I tried to add that whole folder as a collection, and thought it was done because the window was finally non-blank due to blocking io when adding a collection, but after I clicked x to close the program I got:

Creating thumbnail for redacted/monster-slide 4.psd /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide 4.psd Opened with PIL cached at /home/local/FBM/jgustafson/.thumbnails/normal/0fb5fc793b861cdbafa7aa5045ddb74d.png Creating thumbnail for redacted/monster-slide 4A.psd /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide 4A.psd /usr/share/picty/picty/uitools/floats.py:128: GtkWarning: gtk_toolbar_remove: assertion 'content_to_remove != NULL' failed self.mainframe.toolbar1.remove(p.toggle) /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide 4A.psd has no thumbnail. Cannot decode file /run/user/66586672/gvfs/smb-share:server=fcafiles,share=student/redacted/monster-slide 4A.psd Error creating thumbnail for redacted/monster-slide 4A.psd Traceback (most recent call last): File "/usr/share/picty/picty/imagemanip.py", line 963, in make_thumb image = p.close() File "/usr/lib/python2.7/dist-packages/PIL/ImageFile.py", line 423, in close raise IOError("cannot parse this image") IOError: cannot parse this image

Error removing watch Traceback (most recent call last): File "/usr/share/picty/picty/fstools/monitor2.py", line 29, in stop self.wm.rm_watch(wd.values(),rec=self.recursive) File "/usr/lib/python2.7/dist-packages/pyinotify.py", line 2158, in rm_watch del self._wmd[awd] KeyError: 16577

SAVED VIEW <picty.collectiontypes.simpleview.SimpleView instance at 0x7fdd4cae5320> no map source

monster-slide 4A.psd.zip https://github.com/spillz/picty/files/1537669/monster-slide.4A.psd.zip

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/spillz/picty/issues/15#issuecomment-349849548, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFd5StYRyuk0MeRSOFGFnVuIXdwXAcUks5s91clgaJpZM4KHbJL .

spillz commented 6 years ago

Yes, I had started working on user customizations that would allow the user to specify handlers for dds and other file types. Then my long hiatus from open source coding began.... Hope to get back to this one of these days. I still use picty regularly.

On Dec 8, 2017 3:38 PM, "Jacob Gustafson" notifications@github.com wrote:

also there's dds, which can be decoded by ImageMajick which I don't have installed but it could be used if present: https://superuser.com/ questions/159379/convert-dds-to-png-using-linux-command-line

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/spillz/picty/issues/15#issuecomment-350366174, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFd5dwU_Vmey8oVvQ-lSBjUJ74HTvd1ks5s-Z4_gaJpZM4KHbJL .