search

spillz / picty

picty helps you manage photos
57 stars 9 forks source link

picty freezes when creating hundreds of thumbnails #4

Open mcepl opened 10 years ago

mcepl commented 10 years ago

So, I have started picty now, but the only thing I see on my monitor is frozen app and stderr with hundreds of messages like:

Creating thumbnail for 2012/08/Itálie/Ravenna/p20120823_110128.jpg /home/matej/Obrázky/2012/08/Itálie/Ravenna/p20120823_110128.jpg
Opened with GDK
cached at None

If you insist on doing the thumbnails in background, it should really be in some thread or subprocess or something, otherwise the user experience is awful.

spillz commented 10 years ago

It is done on a thread... (but threads in python aren't very good because of the GIL)

Is the app really frozen? Sometimes there is a race condition between the main thread and worker thread that causes the app to spin endlessly trying to generate a thumbnail for an image that should be on screen. If you scroll away from that spot it usually resolves itself.

Otherwise what sort of drive are you scanning? Network drive performance is horrible and leads to long freezes (GIL issue, I think)

And yes, logging needs some attention

mcepl commented 10 years ago

Well, I get the inactive window dialog.

spillz commented 10 years ago

And not a network drive?

mcepl commented 10 years ago

No, local (btrfs filesystem, but that shouldn't matter I hope)