search

spilymp / ibo

Icon Builder for Odoo - IBO - to create appicons in the style of the ERP system "Odoo".
https://spilymp.github.io/ibo/
GNU General Public License v3.0
75 stars 51 forks source link

Add Weather Icons and additional fields #4

Closed PrusDawid closed 2 years ago

PrusDawid commented 2 years ago
spilymp commented 2 years ago

Thank you for your contribution to this little project and your pull request. I took a look and adding the weather icons seems fine. My current problem is the additional font size and weight selection. It works, but I am not happy with the user interface. I have already thought of implementing additional settings, with an additional button for these settings, showing a new page like this: http://jsfiddle.net/qdBEV/3/ Unfortunately, I do not have the time to do this at the moment, so I will not merge your pull request until the user interface issues are resolved. Sorry for the inconvenience. If you want, you can split your request into two parts so that I can accept the weather icons separately or you can help me resolve the UI issues. Otherwise, this request will remain open until further notice.

spilymp commented 2 years ago

Thank you again for your contribution. I added your weather icon commit some time ago and also implemented an option to change the font weight and font size, like you suggested proposed. The latter is inspired by your commits, but not based on them. The reason is that I made changes to the display as previously written as part of the option implementation. Thanks for understanding.