search

spimort / TerraBrush

MIT License
698 stars 27 forks source link

Terrain invisible when closing and returning to scene #101

Closed HEofOttoman closed 3 months ago

HEofOttoman commented 5 months ago

Hello, i have an issue with the plugin when if I save and close the project and I come back later, the terrain disappears and turns invisible. Updating the terrain fixes the problem, but it also removed foliage that have been scattered with another plugin, spatial gardener. When this happens, when I open the project again I am in a different scene. This might mean this is caused when I save and close in another scene, but I am yet to do more testing

HEofOttoman commented 5 months ago

This is also possibly caused by the spatial gardener plugin itself, so I will try updating the plugin and replicating the issue.

Joy-less commented 5 months ago

I can confirm this happens without that plugin. You can also reload the scene to fix it.

spimort commented 5 months ago

Alright! I'll check what could be the cause, I just had this issue as well, trying it.

HEofOttoman commented 5 months ago

Can confirm that spatial gardener was not related to the issue. After updating, the foliage stayed visible, so this might be an issue that the creator of spatial gardener also had and fixed. Update: The opposite happens when the scene is reloaded. (Terrain remains visible, while the foliage disappears)

HEofOttoman commented 5 months ago

I will open a new issue for spatial gardener as well, since a different issue from the other plugin is present as well.

spimort commented 5 months ago

Hey @HEofOttoman , is there any way for you to test the branch fix/terrain-not-loading-if-not-active-scene, it should fix the problem but I'd like to make sure it works for you before I push it to main 🙂

HEofOttoman commented 5 months ago

Hey @HEofOttoman , is there any way for you to test the branch fix/terrain-not-loading-if-not-active-scene, it should fix the problem but I'd like to make sure it works for you before I push it to main 🙂

Ok sure, but one question, how do I update the plugin?

spimort commented 5 months ago

Remove the terrabrush folder from your project and add the new downloaded one from GitHub (you can clone it or download a zip) 🙂

HEofOttoman commented 5 months ago

Thank you, but one quick question: how do I update the plugin? (I sent this message yesterday, but for some reason it disappeared)

spimort commented 5 months ago

Oh, I also answered, strange, don't you see the answer?

Anyways, here : Remove the terrabrush folder from your project and add the new downloaded one from GitHub (you can clone it or download a zip) 🙂

HEofOttoman commented 5 months ago

ok thanks!

HEofOttoman commented 5 months ago

Update: It seems to be fixed, but before I updated I could not replicate the issue

HEofOttoman commented 5 months ago

Edit: Nope, the issue is back image

spimort commented 5 months ago

You are still on the the branch, right? Make sure you compile the project as well (with the hammer button)

HEofOttoman commented 5 months ago

yep,

spimort commented 5 months ago

That is strange, is there anyway for you to share the project with me? Feel free to remove anything that you dont want to share, as long as I can reproduce the situation.

If needed, we can chat on discord, on my server (https://discord.gg/km99TVXEGr)

spimort commented 5 months ago

@HEofOttoman any news on that 🙂?

HEofOttoman commented 4 months ago

I have joined the discord server

spimort commented 4 months ago

@HEofOttoman Cool, I'm not sure I've seen you there but anyway, I did merge the pull request I was talking about (v0.7.1Alpha). I think it fixes the issue but if it's not the case, a sample project would help a ton!

I'll wait to see if you can still reproduce it and in few days I'll close the issue if it's not the case (feel free to reopen one if needed 🙂)

HEofOttoman commented 1 month ago

It seems to be fixed now, thank you very much