jvnknvlgl commented 3 years ago

The extension does not work on GNOME 3.38. It gives the following error in the Extensions application:

's is undefined'

I'm using the Fedora 33 pre-release.

jacobmischka commented 3 years ago

I've dug into this a little bit.

They removed the Calendar.EventsSection, so all of the code in mmcalendar.js related to it needs to be stripped or disabled in 3.38.

Then, Tweener was removed in 3.38, so all of the calls to Tweener need to be stripped out. This can be done relatively easily by dropping 3.32 support and removing the icon hello function that doesn't even seem to be called anywhere.

Once those changes are made the extension will activate without errors, but the overview is pretty broken and doesn't align/sync well. They changed a lot about how geometries are updated since 3.36 it seems. This is where I'm stuck now.

fdinardo commented 3 years ago

Is this extension dropped?

asterlab commented 3 years ago

patch anyone ?

Jhackler commented 3 years ago

usually takes a bit after this extension breaks before it gets fixed/ updated. really wish gnome would just give decent multi-monitor option by default

Jhackler commented 3 years ago

keep up the good work though, I appreciate it.

toupeira commented 3 years ago

@spin83 thank you, latest master fixed it for me on Gnome 3.38.1! :tada:

jacobmischka commented 3 years ago

Can also confirm that it works again, but the animations are a bit clunky when the switcher panel is enabled on non-primary monitors. Regardless, great work and thanks for the quick update!

asterlab commented 3 years ago

Is there a way to have this from the gnome extensions site ?

From: "Jacob Mischka" notifications@github.com To: "spin83/multi-monitors-add-on" multi-monitors-add-on@noreply.github.com Cc: "renato" renato@aster-lab.com, "Comment" comment@noreply.github.com Sent: Monday, October 12, 2020 2:19:29 PM Subject: Re: [spin83/multi-monitors-add-on] Does not work on GNOME 3.38 (#137)

Can also confirm that it works again, but the animations are a bit clunky when the switcher panel is enabled on non-primary monitors. Regardless, great work and thanks for the quick update!

— You are receiving this because you commented. Reply to this email directly, [ https://github.com/spin83/multi-monitors-add-on/issues/137#issuecomment-707085688 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AHKOEYWUWIK2E6R5A2ZUXGTSKLX5DANCNFSM4R4QEK7A | unsubscribe ] .

jvnknvlgl commented 3 years ago

@asterlab it would be nice if you could be a little patient.

Your comment 'patch anyone ?' does not contribute anything to this issue, and comes across as very rude. The developer does this work free of charge, and is in no way obligated to provide this work to you or any other user.

If the developer feels like the code is in a proper state, he or she might decide to upload it on the GNOME Extensions website. You, as a regular user, have two options: wait and see, or actively contribute yourself. The latter option is, of course, possible because this is a GPL 2-licensed project.

In the meantime, see README.md for installation instructions.

fdinardo commented 3 years ago

Thanks @spin83 that worked on gnome 3.38. Great work and great extension. I can't imagine why the gnome team doesn't provide this by default.

About my previous comment, I was just wondering if this extension was dropped, in case, I would have made a fork and try to fix by myself, but with a very long deadline, since I am not an expert developing gnome extensions.

Thanks again!

fulljackz commented 3 years ago

Great work, thanks for all of Ubuntu 20.10 / Gnome 3.38 users :+1:

RSWilli commented 3 years ago

whats the state on this? if it is working, why was the gnome extensions repo not updated?

are there still problems / needed improvements involving the current implementation?

highvoltage commented 3 years ago

@spin83 According to reports above, it seems that master is working in 3.38.1, do you think you can tag a new release?