spinalcordtoolbox / PAM50

https://github.com/neuropoly/spinalcordtoolbox
2 stars 1 forks source link

Is `PAM50_label_spinal_levels.nii.gz` used? #28

Open jcohenadad opened 1 year ago

jcohenadad commented 1 year ago

Searched this string on:

I guess it is safe to remove?

jcohenadad commented 1 year ago

It was added there: https://github.com/spinalcordtoolbox/PAM50/blob/c60362d5b83118290f26dfbd10762429b9829df6/CHANGES.md?plain=1#L7

What for?

jcohenadad commented 1 year ago

Additional info: https://github.com/spinalcordtoolbox/PAM50/commit/59cb6fb2a68beeb5b96b08824c597ba482cce75e

Leading to: https://github.com/spinalcordtoolbox/spinalcordtoolbox/pull/2513 and https://github.com/spinalcordtoolbox/spinalcordtoolbox/issues/2509

jcohenadad commented 1 year ago

So, it is likely that PAM50_label_spinal_levels.nii.gz is useful, because we are now getting the spinal levels from the rootlet segmentation.

My suggestion then, would be to do the same as we do for vertebral/disc levels, ie: