search

spinalcordtoolbox / PAM50

https://github.com/neuropoly/spinalcordtoolbox
2 stars 1 forks source link

Update the histology template to be aligned with the ICBM152 PAM50 #6

Closed valosekj closed 1 year ago

valosekj commented 1 year ago

This PR updates the histology template to be aligned with the ICBM152 PAM50.

Namely, the PR updates the header of the histology template files.

Context: https://github.com/spinalcordtoolbox/spinalcordtoolbox/issues/2179#issuecomment-1463068030 Script used to update the header: here

Fixes: https://github.com/spinalcordtoolbox/spinalcordtoolbox/issues/2179

valosekj commented 1 year ago
I am not authorized to merge this PR: image

@jcohenadad or @joshuacwnewton can you please do it?

Regarding this point:

  • update the URL on sct_download_data

I guess that based on this comment:

(from internal discussion): Might not need to be included in the mainline PAM50 template – could be a separate sct_download_data download.

It will be necessary not only to update the URL but also to add a new option to download.py. Something like PAM50_histology?

jcohenadad commented 1 year ago

Follow-up issues: https://github.com/spinalcordtoolbox/PAM50/issues/7 https://github.com/spinalcordtoolbox/PAM50/issues/8