search

spinalcordtoolbox / manual-correction

Scripts for the manual correction of spinal cord labels
MIT License
4 stars 0 forks source link

JSON files updated despite no manual correction #7

Closed naga-karthik closed 1 year ago

naga-karthik commented 1 year ago

I noticed that even when I don't make any changes to the segmentations, the json sidecars get updated with my name. This should be avoided because the jsons should only be updated only when I make some changes to the segmentation (instead of getting updated for just viewing/checking the segmentations for any errors).

valosekj commented 1 year ago

Thanks for reporting this! So, IIUC, you iterated across subjects and modified the segmentation only for some of them, right? If so, this is indeed a case which the script is not prepared for. The reason is that the script assumes that all files provided in the .yml need at least some corrections.

naga-karthik commented 1 year ago

So, IIUC, you iterated across subjects and modified the segmentation only for some of them, right?

Yes, I checked them and saw that they were alright, and I don't need to do any changes.

naga-karthik commented 1 year ago

Is it because the .yml file is expected to be that of failed cases only?

valosekj commented 1 year ago

Is it because the .yml file is expected to be that of failed cases only?

Exactly!

naga-karthik commented 1 year ago

I guess we should label it won't fix for now