Closed KaterinaKrejci231054 closed 4 months ago
You can also add rootlets into this list: https://github.com/spinalcordtoolbox/manual-correction/blob/main/README.md?plain=1#L5-L12
I added some unit tests for recently implemented get_orientation
and change_orientation
functions (https://github.com/spinalcordtoolbox/manual-correction/pull/100) in https://github.com/spinalcordtoolbox/manual-correction/pull/98/commits/cde09167bfab0af745358a91e6076e8f8cfbe493.
The tests worked fine locally. But when triggered using the GitHub action, the tests failed on missing sct_image
(which is used by get_orientation
and change_orientation
, e.g., here).
sct_image
is missing because we do not currently install SCT for our CI. Not sure if we want to install SCT for our CI as it would increase the CI time a lot...
Hey, @joshuacwnewton! I added SCT installation into the manual_correction CI in https://github.com/spinalcordtoolbox/manual-correction/pull/98/commits/d58dfeefbd4b51c5393848898ec0fc18062cb9c4 and https://github.com/spinalcordtoolbox/manual-correction/pull/98/commits/56b375fd8ad903ff584d08b8aa4e034fe952afd2, but CI still struggles to locate sct_image
:
...
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/subprocess.py:1720: FileNotFoundError
=========================== short test summary info ============================
FAILED tests/test_utils.py::test_get_orientation - FileNotFoundError: [Errno 2] No such file or directory: 'sct_image'
FAILED tests/test_utils.py::test_change_orientation - FileNotFoundError: [Errno 2] No such file or directory: 'sct_image'
========================= 2 failed, 9 passed in 0.40s ==========================
Do you have any ideas on how to solve this?
Thanks for the ping! I have a bit of a backlog to get through since coming back from the conference I was attending, but I'm very happy to take a look at this soon. :)
@KaterinaKrejci231054, thanks for this PR, and @joshuacwnewton, thanks for fixing the CI! LGTM now! merging
This draft PR adds an option to correct rootlets segmentation.
Resolves: #56