Is git installation really necessary?

spinalcordtoolbox / sct_docker

Docker distribution of Spinal Cord Toolbox

3 stars 3 forks source link

Is git installation really necessary? #27

Closed jcohenadad closed 5 years ago

jcohenadad commented 5 years ago

In the README, it says git needs to be installed in order to "provide an SSH binary". I don't see what binary it is referred to here.

Following the installation of sct-docker container, git was only used to git clone the repository in order to execute sct-win.xlaunch, but this could be done by simply downloading the repository as a zip file.

@zougloub can you enlighten me?

zougloub commented 5 years ago

Installation of git for Windows was used because off the top of my head it's an easy way to get OpenSSH utilities (ssh, ssh-keygen, ssh-copy-id... ) on Windows.

jcohenadad commented 5 years ago

but are OpenSSH utilities utilized at some point to run SCT and FSLeyes? If not, I suggest we drop git installation

zougloub commented 5 years ago

Yes, to communicate with the container and do X11 forwarding.