search

spine-generic / data-multi-subject

Multi-subject data for the Spine Generic project
Creative Commons Attribution 4.0 International
22 stars 15 forks source link

Use the mt entity #105

Closed kousu closed 1 year ago

kousu commented 2 years ago

Before https://bids-specification.readthedocs.io/en/stable/99-appendices/09-entities.html#mt was standardized, we'd encoded this information in the acq field. But now we don't have to.

This was done with this script:

find . -name "*_acq-MT*.nii.gz" |
 while read fname; do
   git mv ${fname} ${fname/_acq-MT/_mt-};
 done

Fixes https://github.com/spine-generic/data-multi-subject/issues/103

kousu commented 2 years ago

Despite my "fixes" claim, this doesn't yet deal with the acq-T1w ambiguity (https://github.com/spine-generic/data-multi-subject/issues/103#issuecomment-969503450). Should we deal with that in this PR or in a follow up?

kousu commented 2 years ago

Drafted until it gets redone with mapping acq-T1w -> flip-2_mt-off: https://github.com/spine-generic/data-multi-subject/issues/103#issuecomment-969679915

alexfoias commented 2 years ago

@kousu @jcohenadad Can I take the lead on this PR since I addressed a series of other PRs in the last days? thanks

mguaypaq commented 1 year ago

Fixed in #135 instead.