spine-generic / data-multi-subject

Multi-subject data for the Spine Generic project
Creative Commons Attribution 4.0 International
21 stars 15 forks source link

Refractor derivatives naming convention #157

Closed sandrinebedard closed 3 weeks ago

sandrinebedard commented 5 months ago

Description

Since we have now clarified the naming of the labels in the derivatives, we need to update the derivatives name in spine generic

Suggestions

Note: do we want to add the discs labels from warping from T2w for the other contrasts inside the derivatives? (as we do and need for the contrast-agnostic project)

Related issues

156

154

141

TODO

sandrinebedard commented 5 months ago

tagging @jcohenadad @valosekj @mguaypaq @NathanMolinier

jcohenadad commented 5 months ago

image

Looks good to me! (i'm copy/pasting in case the issue text changes in the future)

Note: do we want to add the discs labels from warping from T2w for the other contrasts inside the derivatives? (as we do and need for the contrast-agnostic project)

I would say yes, so that the contrast-agnostic model can more easily be reproduced, no?

naga-karthik commented 5 months ago

so that the contrast-agnostic model can more easily be reproduced, no?

Yes! We required the disc labels for vertebral labeling and the C2-C3 CSA computation via sct_process_segmentation. Hence, adding the disc labels would be good!

sandrinebedard commented 5 months ago

@NathanMolinier

We have some disc labels that are warped from the T2w, but we want to add them in the derivatives 2 (BUT THEY MAY NOT BE PERFECT) and we do not want to be confused between them and manual disc labels, do you have a suggetsion?

jcohenadad commented 5 months ago

We should also add the space-other field https://github.com/spine-generic/data-multi-subject/issues/156

sandrinebedard commented 5 months ago

I noticed that the disc labels in the derivatives are in the original space LPI, should I reorient them and add space-other to be consitent? or do we keep them in the original space?

NathanMolinier commented 5 months ago

We should also add the space-other field #156

Or space-warp but we need to add this to the JSON sidecar as well to say that the image was warped from another contrast

NathanMolinier commented 5 months ago

I noticed that the disc labels in the derivatives are in the original space LPI, should I reorient them and add space-other to be consitent? or do we keep them in the original space?

Therefore, do we need to store 2 versions of the discs labels ?

sandrinebedard commented 5 months ago

reorientation is a very simple step, I don't think we need 2 versions (in the contrast-agnsotic pipeline, sct_label_vertebrae reorients in any case)