search

spine-generic / data-multi-subject

Multi-subject data for the Spine Generic project
Creative Commons Attribution 4.0 International
22 stars 15 forks source link

Replaced `-` by `n/a` in participants.tsv for BIDS compliance #91

Closed alexfoias closed 2 years ago

alexfoias commented 3 years ago

Ran this script to do the change:

import pandas as pd
df = pd.read_table("/Users/alex/data/data-multi-subject/participants.tsv", encoding="ISO-8859-1")

df_new = df.replace("-", "n/a")
df_new.to_csv("/Users/alex/data/data-multi-subject/participants.tsv", sep='\t', index=False)

Fixes https://github.com/spine-generic/data-multi-subject/issues/89

alexfoias commented 3 years ago

I saw that this removed some " from some fields. @mpompolas could you please check if it breaks something in your pipeline ?

kousu commented 3 years ago

I think pandas is correct here. Those fields should not have had quotes in them.

alexfoias commented 3 years ago

@kousu @jcohenadad can we merge this one ?

jcohenadad commented 3 years ago

does pybids work on this new participants.tsv?

alexfoias commented 3 years ago

Tested it here: https://pastebin.com/eNNPy8kq

jcohenadad commented 2 years ago

@alexfoias can you pls resolve conflicts

alexfoias commented 2 years ago

@kousu I've realized that I did a mistake and I want to drop the previous commit https://github.com/spine-generic/data-multi-subject/pull/91/commits/ac4681a5661ac2cd40326e5ca760837c679fc70c not sure how to do it without breaking things. Could you please help me ? thanks

alexfoias commented 2 years ago

@jcohenadad we are ready to merge this one.

jcohenadad commented 2 years ago

@alexfoias can you please update this PR after #112

alexfoias commented 2 years ago

@jcohenadad we can abandon this PR and not merge because the master already has n/a.