search

spine-generic / data-multi-subject

Multi-subject data for the Spine Generic project
Creative Commons Attribution 4.0 International
22 stars 15 forks source link

Fix software version #97

Closed alexfoias closed 2 years ago

alexfoias commented 2 years ago

The problem was reported by external collaborator on Oct 8, 2021

to merge after https://github.com/spine-generic/data-multi-subject/pull/109

alexfoias commented 2 years ago

I have checked the BIDSification script and everything seems fine. These fields were added manually to the participants.tsv file, hence human error from dragging the cells.

jcohenadad commented 2 years ago

@alexfoias can you pls update the branch

alexfoias commented 2 years ago

@jcohenadad I updated the branch.

jcohenadad commented 2 years ago

@alexfoias can you please update this PR after https://github.com/spine-generic/data-multi-subject/pull/112

jcohenadad commented 2 years ago

at some point it would be great to make the validator more flexible because we keep merging with the validator failing...

alexfoias commented 2 years ago

We had an error because of the /scripts folder. Changed it to be compliant as per documentation https://bids-specification.readthedocs.io/en/stable/03-modality-agnostic-files.html#code

alexfoias commented 2 years ago

@jcohenadad the https://github.com/spine-generic/data-multi-subject/pull/97/commits/1bb0a3261b0c34c0583a309969299746abb21cf2 seemed to have fixed the issue. We can merge it.