spine-tools / Spine-Database-API

Database interface to Spine generic data model
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
6 stars 5 forks source link

Raise errors in opening DB maps from server #204

Closed manuelma closed 1 year ago

manuelma commented 1 year ago

Otherwise we could get something like "invalid request get_db_url" which doesn't say at all what the actual error is.

Checklist before merging

codecov-commenter commented 1 year ago

Codecov Report

Base: 74.40% // Head: 74.38% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (fdd391b) compared to base (353fd33). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #204 +/- ## ========================================== - Coverage 74.40% 74.38% -0.03% ========================================== Files 71 71 Lines 11711 11715 +4 Branches 2270 2272 +2 ========================================== Hits 8714 8714 - Misses 2550 2554 +4 Partials 447 447 ``` | [Impacted Files](https://codecov.io/gh/Spine-project/Spine-Database-API/pull/204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Spine-project) | Coverage Δ | | |---|---|---| | [spinedb\_api/spine\_db\_server.py](https://codecov.io/gh/Spine-project/Spine-Database-API/pull/204/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Spine-project#diff-c3BpbmVkYl9hcGkvc3BpbmVfZGJfc2VydmVyLnB5) | `32.35% <0.00%> (-0.35%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Spine-project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Spine-project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.