search

spine-tools / Spine-Database-API

Database interface to Spine generic data model
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
6 stars 5 forks source link

Add unit-tests for the DB server? #209

Closed manuelma closed 6 months ago

manuelma commented 1 year ago

We don't have many or any tests for this and we might want to keep using it in Mopo?

soininen commented 1 year ago

I believe adding tests is well worth it. We do not have definitive plans on replacing anything yet and if such time comes to pass it might be far in the future.

jkiviluo commented 1 year ago

Doesn't it also depend on whether we are thinking about doing risky changes to the current DB server? Don't need to be high risk. I mean if we are not, then we can push making those tests further down the road (or don't do them, if we do a rewrite in another language).

soininen commented 1 year ago

Doesn't it also depend on whether we are thinking about doing risky changes to the current DB server?

Every change is risky as you might touch code that you think is unrelated but still breaks stuff somewhere else. Having at least the basic tests now would give us more confidence in our code.

manuelma commented 6 months ago

Something done in https://github.com/spine-tools/Spine-Database-API/pull/369, closing now...