search

spine-tools / Spine-Database-API

Database interface to Spine generic data model
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
6 stars 5 forks source link

Relationship object highlighting export mappings don't scale #244

Closed soininen closed 1 year ago

soininen commented 1 year ago

The query returned by RelationshipObjectHighlightingMapping.filter_query() doesn't scale and in fact hits a max query size limit when a relationship class contains enough relationships.

manuelma commented 1 year ago

This has been heavily refactored in that other branch about the entity... So if we fix this issue in master, I doubt we will be able to merge it into the entity branch later. So it might be a good idea to describe the fix in words here so we can apply it to that entity branch??

manuelma commented 1 year ago

That said, I think there is an argument to be made about accepting to live with some bugs in 0.7 that do not bother much and we can fix in 0.8? What do you think?

soininen commented 1 year ago

So it might be a good idea to describe the fix in words here so we can apply it to that entity branch??

I could also try fixing it in the entity branch separately and if that fails, try to describe the fix here in-depth.

That said, I think there is an argument to be made about accepting to live with some bugs in 0.7 that do not bother much and we can fix in 0.8?

If this was just a small nuisance, then sure, but it is actually a critical bug that prevents certain workflows from running so I'm afraid we'll have to fix it for 0.7.