We call cascade_remove_items() from Toolbox without supplying db cache apparently to ensure that all cascading ids get cached in cascading_ids(). The call to make_cache(), however, overwrote all existing items in the cache destroying pending updates. We now supply a new parameter, keep_existing, to make_cache() to prevent overwriting existing items.
Fixes spine-tools/Spine-Toolbox#2259
Checklist before merging
[x] Documentation (also in Toolbox repo) is up-to-date
[x] Release notes in Toolbox repo have been updated
[x] Unit tests have been added/updated accordingly
We call
cascade_remove_items()from Toolbox without supplying db cache apparently to ensure that all cascading ids get cached incascading_ids(). The call tomake_cache(), however, overwrote all existing items in the cache destroying pending updates. We now supply a new parameter,keep_existing, tomake_cache()to prevent overwriting existing items.Fixes spine-tools/Spine-Toolbox#2259
Checklist before merging