spine-tools / Spine-Database-API

Database interface to Spine generic data model
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
6 stars 5 forks source link

Fix purging #263

Closed soininen closed 11 months ago

soininen commented 11 months ago

We need to make sure all purgeable items are in database cache before removing them.

Fixes #261

Checklist before merging

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.28% :tada:

Comparison is base (2736e13) 75.58% compared to head (fe168e4) 75.87%. Report is 3 commits behind head on 0.8-dev.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.8-dev #263 +/- ## =========================================== + Coverage 75.58% 75.87% +0.28% =========================================== Files 73 73 Lines 8783 8784 +1 Branches 1853 1854 +1 =========================================== + Hits 6639 6665 +26 + Misses 1819 1791 -28 - Partials 325 328 +3 ``` | [Files Changed](https://app.codecov.io/gh/spine-tools/Spine-Database-API/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools) | Coverage Δ | | |---|---|---| | [spinedb\_api/purge.py](https://app.codecov.io/gh/spine-tools/Spine-Database-API/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools#diff-c3BpbmVkYl9hcGkvcHVyZ2UucHk=) | `51.35% <ø> (+51.35%)` | :arrow_up: | | [spinedb\_api/db\_mapping\_remove\_mixin.py](https://app.codecov.io/gh/spine-tools/Spine-Database-API/pull/263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools#diff-c3BpbmVkYl9hcGkvZGJfbWFwcGluZ19yZW1vdmVfbWl4aW4ucHk=) | `76.92% <100.00%> (+6.33%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/spine-tools/Spine-Database-API/pull/263/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.