spine-tools / Spine-Database-API

Database interface to Spine generic data model
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
6 stars 5 forks source link

Fix scenario filter for entity alternatives #352

Closed soininen closed 4 months ago

soininen commented 4 months ago

This fixes a special case where an entity has entity alternative in an alternative that is not part of any scenario. Such entities are now properly filtered out when using the scenario filter.

Fixes #spine-tools/Spine-Toolbox#2504

Checklist before merging

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b92facd) 77.39% compared to head (c33f91b) 77.39%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.8-dev #352 +/- ## ======================================== Coverage 77.39% 77.39% ======================================== Files 75 75 Lines 9283 9283 Branches 1957 1957 ======================================== Hits 7185 7185 Misses 1773 1773 Partials 325 325 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

manuelma commented 4 months ago

Thank you very much for this @soininen