Refresh cache aggressively after filter change

spine-tools / Spine-Database-API

Database interface to Spine generic data model

https://www.tools-for-energy-system-modelling.org/

GNU Lesser General Public License v3.0

6 stars 5 forks source link

Refresh cache aggressively after filter change #364

Closed manuelma closed 7 months ago

manuelma commented 7 months ago

To make sure things work, I propose we refresh the entire cache after changing a filter instead of trying to change only the affected tables. We were failing to do that correctly and it has brought a lot of problems.

Fixes #363

Checklist before merging

[x] Documentation (also in Toolbox repo) is up-to-date
[x] Release notes in Toolbox repo have been updated
[x] Unit tests have been added/updated accordingly
[x] Code has been formatted by black
[x] Unit tests pass

manuelma commented 7 months ago

@jkiviluo @soininen I would like to merge this patch to master. It is a very small change (just one line), what do you think? It solves a very annoying bug #363

manuelma commented 7 months ago

Looks like I need to fix a test though...

soininen commented 7 months ago

I would like to merge this patch to master.

That should be totally fine.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e29d197) 75.32% compared to head (95d4b8c) 75.25%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #364 +/- ## ========================================== - Coverage 75.32% 75.25% -0.08% ========================================== Files 76 71 -5 Lines 10984 10959 -25 Branches 2391 2391 ========================================== - Hits 8274 8247 -27 Misses 2272 2272 - Partials 438 440 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.