Open soininen opened 1 week ago
Attention: Patch coverage is 86.66667%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 78.24%. Comparing base (
c630744
) to head (5a8b129
).
Files | Patch % | Lines |
---|---|---|
...versions/ca7a13da8ff6_add_type_info_for_scalars.py | 84.37% | 3 Missing and 2 partials :warning: |
spinedb_api/parameter_value.py | 87.50% | 2 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This should not be merged before SpineInterface has been updated accordingly.
Floats, booleans and strings now have explicit types in
parameter_definition
,parameter_value
andlist_value
tables. This means that the values now always carry the type information with them; only when the value is None, the type is None as well.Implements #356
Checklist before merging