spine-tools / Spine-Toolbox

Spine Toolbox is an open source Python package to manage data, scenarios and workflows for modelling and simulation. You can have your local workflow, but work as a team through version control and SQL databases.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
73 stars 18 forks source link

Fix (nearly) endless database upgrade dialogs #2916

Closed soininen closed 3 months ago

soininen commented 3 months ago

This PR fixes a bug where multiple database upgrade dialogs would pop up for a single Data store if user kept cancelling the dialogs. We now ask just once if an upgrade is desirable, though users are given a second chance if they try to open the DB in the editor.

Fixes #2915

Checklist before merging

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.94%. Comparing base (deb9cbe) to head (57fa23a).

Files Patch % Lines
spinetoolbox/spine_db_manager.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2916 +/- ## ======================================= Coverage 66.93% 66.94% ======================================= Files 189 189 Lines 36887 36890 +3 Branches 6314 6314 ======================================= + Hits 24690 24695 +5 + Misses 10884 10883 -1 + Partials 1313 1312 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.