search

spine-tools / Spine-Toolbox

Spine Toolbox is an open source Python package to manage data, scenarios and workflows for modelling and simulation. You can have your local workflow, but work as a team through version control and SQL databases.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
73 stars 18 forks source link

Segfaults in unit tests #2921

Closed soininen closed 1 month ago

soininen commented 3 months ago

I changed unit tests such that they clean up memory reserved by Qt in 7c7c6f1d867044a1c24447ada309c74bcd6d0c3f which allows me to run the tests on a Linux virtual machine with limited memory resources. The change, however, seems to have made the tests crash randomly on a segfault.

Also, even with the clean up, the memory consumption increases almost monotonically during the tests which may be a sign of a memory leak. Either we could clean up more rigorously in the tests, or we have some QObjects that never get deleted while Toolbox or DB editor is running.

soininen commented 1 month ago

I firmly believe the segfaults happened only on Python 3.8 ;) Since we have now dropped support for that, we should not see the segfaults again. Please reopen this is if I am proven wrong.