search

spine-tools / Spine-Toolbox

Spine Toolbox is an open source Python package to manage data, scenarios and workflows for modelling and simulation. You can have your local workflow, but work as a team through version control and SQL databases.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
73 stars 18 forks source link

Alternative filter does not filter entity alternatives (just parameters) #3004

Closed nnhjy closed 1 week ago

nnhjy commented 2 weeks ago

Please replicate the issue with this DB testin.zip, where the unitB with entity alternative being false in "Base" alternative will still be passed to another DB by a Merger.

jkiviluo commented 2 weeks ago

Right. It seems like alternative filter is not working as expected. Not just for the merger tool, but also for other tools and exporter. It filters parameter data, but not entities. Scenario filter does work though.

It's not just that setting entity alternative to 'false' does not filter out those entities, but all entities are always passed forward. They should not be unless they are part of the selected alternatives (either through setting true or through 'active by default' - although in case of ND entities all the parent entities should be active of course).

soininen commented 2 weeks ago

Entity alternatives have not been implemented for the alternative filter yet.

soininen commented 1 week ago

Alternative filter is now feature-complete.