search

spine-tools / Spine-Toolbox

Spine Toolbox is an open source Python package to manage data, scenarios and workflows for modelling and simulation. You can have your local workflow, but work as a team through version control and SQL databases.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
73 stars 18 forks source link

Remove the Filter action from DB editor #3007

Closed soininen closed 1 week ago

soininen commented 1 week ago

This removes the Filter icon, the associated QAction and all related code from DB editor. The action was redundant and didn't work very well.

Resolves #2820

Checklist before merging

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.12%. Comparing base (9a5c21b) to head (5aa424e). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3007 +/- ## ========================================== - Coverage 67.15% 67.12% -0.04% ========================================== Files 193 193 Lines 37138 37011 -127 Branches 4450 4443 -7 ========================================== - Hits 24940 24843 -97 + Misses 10941 10913 -28 + Partials 1257 1255 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

manuelma commented 1 week ago

I wish we could have fixed this instead of deleting it, but maybe for another day. The filter action was great to see exactly what the tool was getting after applying the filter.