search

spine-tools / Spine-Toolbox

Spine Toolbox is an open source Python package to manage data, scenarios and workflows for modelling and simulation. You can have your local workflow, but work as a team through version control and SQL databases.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
70 stars 17 forks source link

GAMS and Julia Tools won't work if there are spaces in the work directory path #93

Closed spine-o-bot closed 3 years ago

spine-o-bot commented 3 years ago

In GitLab by @PekkaSavolainen on Jun 20, 2018, 15:30

When users install the application into a directory that contains spaces e.g. C:\Program Files\Spine Toolbox the path to work folder becomes C:\Program Files\Spine Toolbox\work. Both Julia and GAMS tools fail to start when trying to use this as a work folder.

spine-o-bot commented 3 years ago

In GitLab by @PekkaSavolainen on Jun 20, 2018, 19:11

mentioned in commit 00be52f74aa1406fa9498d64bf4680a2d4bfabca

spine-o-bot commented 3 years ago

In GitLab by @manuelma on Jun 21, 2018, 10:27

It looks like this is not a problem with Julia tools on Linux. Check the event log below (note there's a space between test and spine in the folder name):

[21-06-2018 09:27:45] Executing Tool tool [21-06-2018 09:27:45] Work Directory: /home/manuelma/Codes/test spine/toolbox/work/julia_test__f1skxzlz__toolbox [21-06-2018 09:27:45] *** Copying Tool Julia test to work directory *** [21-06-2018 09:27:45] Copied 1 file(s) [21-06-2018 09:27:45] *** Searching for required input files *** [21-06-2018 09:27:45] Reference for branch.csv found in DC branch [21-06-2018 09:27:45] *** Copying input files to work directory *** [21-06-2018 09:27:45] Copying branch.csv [21-06-2018 09:27:45] Copied 1 file(s) [21-06-2018 09:27:45] *** Starting Tool Julia test *** [21-06-2018 09:27:45] cd("/home/manuelma/Codes/test spine/toolbox/work/julia_test__f1skxzlz__toolbox");include("test.jl") [21-06-2018 09:27:45] Starting Julia REPL... [21-06-2018 09:28:06] Julia Tool finished successfully. Return code:0 [21-06-2018 09:28:07] *** Saving result files *** [21-06-2018 09:28:07] No files saved to result directory [21-06-2018 09:28:07] Warning: Check 'outputfiles' in tool definition [21-06-2018 09:28:07] Done [21-06-2018 09:28:07] Result Directory: /home/manuelma/Codes/test spine/toolbox/projects/test1/tool/output/2018-06-21T09.28.07 [21-06-2018 09:28:07] Tool Julia test execution finished

spine-o-bot commented 3 years ago

In GitLab by @PekkaSavolainen on Aug 16, 2018, 11:33

@manuelma I'm looking at this now. You are correct. It works when using REPL. Try it without the REPL and it should fail.

spine-o-bot commented 3 years ago

In GitLab by @manuelma on Aug 16, 2018, 11:35

Ah maybe it makes sense. The REPL understands the cd(work_directory) command whereas the qsubprocess doesn't, something like that?

spine-o-bot commented 3 years ago

In GitLab by @PekkaSavolainen on Aug 16, 2018, 15:33

Got this finally fixed. Looks like our QProcess.start() method was not called in a correct way. Commit coming up soon.

spine-o-bot commented 3 years ago

In GitLab by @PekkaSavolainen on Aug 16, 2018, 15:36

mentioned in commit 9d709516f0ece0ee286ad08cc49c840292e5b4ea

spine-o-bot commented 3 years ago

In GitLab by @PekkaSavolainen on Aug 16, 2018, 15:54

closed