spine-tools / SpineOpt.jl

A highly adaptable modelling framework for multi-energy systems
https://www.tools-for-energy-system-modelling.org/
GNU General Public License v3.0
58 stars 14 forks source link

(Possible) error in Capacity Planning Tutorial #1128

Open tbaptistal opened 3 weeks ago

tbaptistal commented 3 weeks ago

Capacity Planning Tutorial

This is the updated version: image

This is the old version: image

Additional context https://spine-tools.github.io/SpineOpt.jl/latest/tutorial/figs_capacity_planning/capacity_temporal.png https://spine-tools.github.io/SpineOpt.jl/latest/tutorial/figs_capacity_planning/multi-year_temporal.png

datejada commented 3 weeks ago

@gnawin, would you mind taking a look at this? It is related to the investment tutorials. Thanks!

gnawin commented 3 weeks ago

Hi @tbaptistal,

Thanks for providing feedback. However, I think I did not fully get what you meant. Could you elaborate a bit?

The tutorial starts with the simple system (where there are already 2 connectors between simple and deterministic), and we add the 3rd one for investment. Did you mean that we should only have 2?

tbaptistal commented 2 weeks ago

Hi @gnawin, Thank you for your quick answer! My simple system looks like the tutorial with only 1 connection between simple and deterministic : image

And then for the investment tutorial I only add 1 connection between simple and deterministic : the default investment connector

Also when I search in the menu to connect these 2 blocks (simple and deterministic), only 2 connectors are valid between the classes _stochasticstructure and model : image

So yes, I feel that in the investment we should only have 2 connections between simple and deterministic

gnawin commented 2 weeks ago

Hi @tbaptistal, Thanks for the elaboration. Indeed, we need to look into this.

@tarskul it seems something is off in the simple system tutorial, this is what I see in the docs:

image

and this is what I see when I load the simple_system.json from the examples folder:

image

The number of connections between simple and deterministic are different (which caused confusion for @tbaptistal). I suppose we need to update the figure(s) in the docs of the simple system?

tarskul commented 1 week ago

If I'm not mistaken, both are possible. The figure in the documentation is actually more recent than the json file. It has been a while but I'm pretty sure that the system worked when I created the figure. I was waiting to update the json file until after the upcoming big structural changes.

gnawin commented 5 days ago

Hi @tbaptistal,

So @tarskul (who documented the simple tutorial) confirms that both should be possible. And that there is some discrepancy between what's documented and what's actually provided in the examples jsons. As a result, there also comes some inconsistency between the different tutorials.

Thank you for pointing out this, and we will make sure they are consistent when we review the tutorials again after the upcoming structural changes.