spine-tools / spine-items

Project items for Spine Toolbox.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
4 stars 4 forks source link

fix importer pivot forces ignored column data type to float #138

Closed PiispaH closed 1 year ago

PiispaH commented 1 year ago

It used to be that only columns that were not pivoted didn't have their data types changed to floats. Now also ignored columns from Mapping options are excluded from the conversion.

Fixes spine-tools/Spine-Toolbox#2158

Checklist before merging

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (ca93d77) 54.95% compared to head (0f64541) 54.95%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #138 +/- ## ========================================== - Coverage 54.95% 54.95% -0.01% ========================================== Files 192 192 Lines 17298 17300 +2 Branches 2836 2836 ========================================== + Hits 9506 9507 +1 - Misses 7298 7300 +2 + Partials 494 493 -1 ``` | [Impacted Files](https://app.codecov.io/gh/spine-tools/spine-items/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools) | Coverage Δ | | |---|---|---| | [spine\_items/importer/mvcmodels/mappings\_model.py](https://app.codecov.io/gh/spine-tools/spine-items/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools#diff-c3BpbmVfaXRlbXMvaW1wb3J0ZXIvbXZjbW9kZWxzL21hcHBpbmdzX21vZGVsLnB5) | `53.46% <0.00%> (-0.15%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/spine-tools/spine-items/pull/138/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.