spine-tools / spine-items

Project items for Spine Toolbox.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
4 stars 4 forks source link

Adapt ToolInstances to ExecutionManager changes #166

Closed ptsavol closed 10 months ago

ptsavol commented 10 months ago

This PR cleans up ToolInstance classes and adapts ExecutionManager instantiations to changes on spine-engine's PR https://github.com/spine-tools/spine-engine/pull/118.

Re spine-tools/spine-engine#117

Checklist before merging

codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6320d83) 59.72% compared to head (f115efb) 59.85%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.8-dev #166 +/- ## =========================================== + Coverage 59.72% 59.85% +0.12% =========================================== Files 193 193 Lines 17546 17550 +4 Branches 2847 2847 =========================================== + Hits 10480 10504 +24 + Misses 6502 6488 -14 + Partials 564 558 -6 ``` | [Files](https://app.codecov.io/gh/spine-tools/spine-items/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools) | Coverage Δ | | |---|---|---| | [spine\_items/tool/tool\_instance.py](https://app.codecov.io/gh/spine-tools/spine-items/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools#diff-c3BpbmVfaXRlbXMvdG9vbC90b29sX2luc3RhbmNlLnB5) | `95.81% <100.00%> (+8.13%)` | :arrow_up: | | [spine\_items/tool/tool\_specifications.py](https://app.codecov.io/gh/spine-tools/spine-items/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools#diff-c3BpbmVfaXRlbXMvdG9vbC90b29sX3NwZWNpZmljYXRpb25zLnB5) | `83.47% <ø> (+0.86%)` | :arrow_up: | | [spine\_items/tool/utils.py](https://app.codecov.io/gh/spine-tools/spine-items/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools#diff-c3BpbmVfaXRlbXMvdG9vbC91dGlscy5weQ==) | `75.86% <50.00%> (+0.86%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/spine-tools/spine-items/pull/166/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spine-tools)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.