spine-tools / spine-items

Project items for Spine Toolbox.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
4 stars 4 forks source link

Fix storing/loading database references for Data connections #175

Closed soininen closed 10 months ago

soininen commented 10 months ago

This PR fixes a bug where database credentials were always stored under "None" instead of sanitized database URL.

Re spine-tools/Spine-Toolbox#2329

Checklist before merging

codecov-commenter commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (37f0ab2) 60.22% compared to head (22e6870) 60.27%.

Files Patch % Lines
spine_items/utils.py 93.54% 1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.8-dev #175 +/- ## =========================================== + Coverage 60.22% 60.27% +0.04% =========================================== Files 194 194 Lines 17678 17682 +4 Branches 2886 2887 +1 =========================================== + Hits 10647 10658 +11 + Misses 6462 6457 -5 + Partials 569 567 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.