spine-tools / spine-items

Project items for Spine Toolbox.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
4 stars 4 forks source link

Fix creating system images #180

Closed ptsavol closed 9 months ago

ptsavol commented 10 months ago

Fixes two bugs in sysimage creation:

Re spine-tools/Spine-Toolbox#2451

Checklist before merging

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (082ca23) 60.25% compared to head (e9b9de1) 60.28%. Report is 2 commits behind head on 0.8-dev.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.8-dev #180 +/- ## =========================================== + Coverage 60.25% 60.28% +0.02% =========================================== Files 194 194 Lines 17687 17687 Branches 2887 2887 =========================================== + Hits 10658 10662 +4 + Misses 6462 6458 -4 Partials 567 567 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ptsavol commented 9 months ago

Commit f8e4592 makes a syimage file successfully but when I try to use the sysimage while running the tool, it gives me this Traceback. I don't know how to fix it so I'll try something else next.

julia> # Running julia run_spineopt.jl http://127.0.0.1:55331 http://127.0.0.1:55334
2-element Vector{String}:
 "http://127.0.0.1:55331"
 "http://127.0.0.1:55334"

Execution started at 2023-12-20T16:48:13.170
Preparing SpineOpt for sqlite:///C:\data\SpineToolboxData\Projects\SpineOptProject_III_0.8-dev\.spinetoolbox\items\input\input.sqlite...
Initializing data structure from db...
ERROR: LoadError: MethodError: no method matching getindex(::Module, ::String)
Stacktrace:
  [1] difference(left::Module, right::Module)
    @ SpineInterface C:\Users\ttepsa\.julia\packages\SpineInterface\CNP7u\src\api\core.jl:625
  [2] macro expansion
    @ C:\Users\ttepsa\.julia\packages\SpineOpt\ifkx1\src\run_spineopt.jl:239 [inlined]
  [3] macro expansion
    @ .\timing.jl:273 [inlined]
  [4] macro expansion
    @ C:\Users\ttepsa\.julia\packages\SpineOpt\ifkx1\src\util\misc.jl:51 [inlined]
  [5] prepare_spineopt(url_in::String; upgrade::Bool, log_level::Int64, filters::Dict{String, String})
    @ SpineOpt C:\Users\ttepsa\.julia\packages\SpineOpt\ifkx1\src\run_spineopt.jl:230
  [6] _run_spineopt(url_in::String, url_out::String; upgrade::Bool, mip_solver::Nothing, lp_solver::Nothing, add_user_variables::Function, add_constraints::Function, log_level::Int64, optimize::Bool, update_names::Bool, alternative::String, write_as_roll::Int64, use_direct_model::Bool, filters::Dict{String, String}, resume_file_path::Nothing)
    @ SpineOpt C:\Users\ttepsa\.julia\packages\SpineOpt\ifkx1\src\run_spineopt.jl:186
  [7] run_spineopt(url_in::String, url_out::String; upgrade::Bool, mip_solver::Nothing, lp_solver::Nothing, add_user_variables::Function, add_constraints::Function, log_level::Int64, optimize::Bool, update_names::Bool, alternative::String, write_as_roll::Int64, use_direct_model::Bool, filters::Dict{String, String}, log_file_path::Nothing, resume_file_path::Nothing)
    @ SpineOpt C:\Users\ttepsa\.julia\packages\SpineOpt\ifkx1\src\run_spineopt.jl:98
  [8] run_spineopt(url_in::String, url_out::String)
    @ SpineOpt C:\Users\ttepsa\.julia\packages\SpineOpt\ifkx1\src\run_spineopt.jl:79
  [9] top-level scope
    @ C:\Users\ttepsa\.spinetoolbox\work\run_spineopt__b76fd529445448d3b1b00ce904728841__toolbox\run_spineopt.jl:3
 [10] include(fname::String)
    @ Base.MainInclude .\client.jl:478
 [11] top-level scope
    @ none:1
in expression starting at C:\Users\ttepsa\.spinetoolbox\work\run_spineopt__b76fd529445448d3b1b00ce904728841__toolbox\run_spineopt.jl:3