spine-tools / spine-items

Project items for Spine Toolbox.
https://www.tools-for-energy-system-modelling.org/
GNU Lesser General Public License v3.0
4 stars 4 forks source link

Replace ProjectItemModel related stuff #187

Closed ptsavol closed 7 months ago

ptsavol commented 8 months ago

This PR removes ProjectItemModel dependency from spine-items

Fixes spine-tools/Spine-Toolbox#2560

Checklist before merging

soininen commented 8 months ago

Do we use the item categories for anything after ProjectItemModel is gone?

ptsavol commented 8 months ago

Do we use the item categories for anything after this change?

No, category.py is gone.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b86ccec) 60.18% compared to head (f080448) 60.66%.

Files Patch % Lines
...ne_items/data_transformer/specification_factory.py 0.00% 1 Missing :warning:
...tems/data_transformer/widgets/class_tree_widget.py 0.00% 1 Missing :warning:
.../data_transformer/widgets/parameter_tree_widget.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.8-dev #187 +/- ## =========================================== + Coverage 60.18% 60.66% +0.48% =========================================== Files 194 193 -1 Lines 17789 17686 -103 Branches 2902 2875 -27 =========================================== + Hits 10706 10729 +23 + Misses 6509 6374 -135 - Partials 574 583 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

soininen commented 8 months ago

No, category.py is gone.

That is so nice! We could then drop the category stuff from ItemInfo as well if that was not included in these PRs already.